Discussion:
[pve-devel] [PATCH manager] do not send 'undefined' as romfile
Dominik Csapak
2018-12-05 12:25:25 UTC
Permalink
when adding a pcidevice, we added 'romfile=undefined' by accident

Signed-off-by: Dominik Csapak <***@proxmox.com>
---
www/manager6/qemu/PCIEdit.js | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 40a7d8c7..85d1f4ce 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -55,6 +55,10 @@ Ext.define('PVE.qemu.PCIInputPanel', {
values.rombar = 0;
}

+ if (!values.romfile) {
+ delete values.romfile;
+ }
+
ret[me.confid] = PVE.Parser.printPropertyString(values, 'host');
return ret;
},
--
2.11.0
Thomas Lamprecht
2018-12-05 13:26:09 UTC
Permalink
On 12/5/18 1:25 PM, Dominik Csapak wrote:> when adding a pcidevice, we added 'romfile=undefined' by accident
Post by Dominik Csapak
---
www/manager6/qemu/PCIEdit.js | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 40a7d8c7..85d1f4ce 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -55,6 +55,10 @@ Ext.define('PVE.qemu.PCIInputPanel', {
values.rombar = 0;
}
+ if (!values.romfile) {
+ delete values.romfile;
+ }
+
ret[me.confid] = PVE.Parser.printPropertyString(values, 'host');
return ret;
},
applied, thanks!

Loading...