Discussion:
[pve-devel] [PATCH storage] Fix #2019: CephFS storage misses maxfiles
Alwin Antreich
2018-12-07 08:02:58 UTC
Permalink
Signed-off-by: Alwin Antreich <***@proxmox.com>
---
PVE/Storage/CephFSPlugin.pm | 1 +
1 file changed, 1 insertion(+)

diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm
index 1bfdd01..ebd6eec 100644
--- a/PVE/Storage/CephFSPlugin.pm
+++ b/PVE/Storage/CephFSPlugin.pm
@@ -118,6 +118,7 @@ sub options {
mkdir => { optional => 1 },
fuse => { optional => 1 },
bwlimit => { optional => 1 },
+ maxfiles => { optional => 1 },
};
}
--
2.11.0
Thomas Lamprecht
2018-12-07 12:47:46 UTC
Permalink
Post by Alwin Antreich
---
PVE/Storage/CephFSPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm
index 1bfdd01..ebd6eec 100644
--- a/PVE/Storage/CephFSPlugin.pm
+++ b/PVE/Storage/CephFSPlugin.pm
@@ -118,6 +118,7 @@ sub options {
mkdir => { optional => 1 },
fuse => { optional => 1 },
bwlimit => { optional => 1 },
+ maxfiles => { optional => 1 },
};
}
applied, thanks!
Thomas Lamprecht
2018-12-07 13:11:53 UTC
Permalink
---
www/manager6/storage/CephFSEdit.js | 13 ++++++++++++-
www/manager6/storage/RBDEdit.js | 2 +-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/www/manager6/storage/CephFSEdit.js b/www/manager6/storage/CephFSEdit.js
index 0580e8fc..fff68b1d 100644
--- a/www/manager6/storage/CephFSEdit.js
+++ b/www/manager6/storage/CephFSEdit.js
@@ -69,9 +69,20 @@ Ext.define('PVE.storage.CephFSInputPanel', {
cts: ['backup', 'iso', 'vztmpl'],
fieldLabel: gettext('Content'),
name: 'content',
- value: ['backup'],
+ value: 'backup',
multiSelect: true,
allowBlank: false
+ },
+ {
+ xtype: 'proxmoxintegerfield',
+ fieldLabel: gettext('Max Backups'),
+ disabled: true,
applied, but removed the above line as a fixup, as this is not valid for CephFS.
You probably copied it from a storage plugin which has 'backup' not included in the
default content type selection, so there the initial state has to be disabled.
But with CephFS this isn't the case, there backup is the default (allowed) content
type and thus this need to be enabled from the start...
+ name: 'maxfiles',
+ reference: 'maxfiles',
+ minValue: 0,
+ maxValue: 365,
+ value: me.isCreate ? '1' : undefined,
+ allowBlank: false
}
];
diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js
index c38759df..4ecd98e4 100644
--- a/www/manager6/storage/RBDEdit.js
+++ b/www/manager6/storage/RBDEdit.js
@@ -10,7 +10,7 @@ Ext.define('PVE.storage.Ceph.Model', {
});
Ext.define('PVE.storage.Ceph.Controller', {
- extend: 'Ext.app.ViewController',
+ extend: 'PVE.controller.StorageEdit',
alias: 'controller.cephstorage',
control: {
Loading...